davidradl commented on code in PR #25629:
URL: https://github.com/apache/flink/pull/25629#discussion_r1871258919
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/TimeWindowUtil.java:
##########
@@ -194,10 +198,12 @@ public static long getNextTriggerWatermark(
if (useDayLightSaving) {
long utcWindowStart =
getWindowStartWithOffset(
- toUtcTimestampMills(currentWatermark,
shiftTimezone), 0L, interval);
Review Comment:
we should have unit tests for this with different window offsets and
timezones and DLS.
I am curious is the watermark time always local - or can it ever be UTC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
