reswqa commented on code in PR #25729:
URL: https://github.com/apache/flink/pull/25729#discussion_r1871199902


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/LookupJoinHintOptions.java:
##########
@@ -100,6 +100,12 @@ public class LookupJoinHintOptions {
                     .noDefaultValue()
                     .withDescription("Max attempt number of the 'fixed-delay' 
retry strategy.");
 
+    public static final ConfigOption<Boolean> SHUFFLE =
+            key("shuffle")

Review Comment:
   This pr not only introduced custom shuffle, but also support hash shuffle 
for lookup join input stream. Without this shuffle hint, input stream is not 
distributed by join key.
   
   if lookup source doesn't impl `SupportsLookupCustomShuffle`, plan also try 
to apply a hash distribution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to