yunfengzhou-hub commented on code in PR #25729:
URL: https://github.com/apache/flink/pull/25729#discussion_r1871053005
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/LookupJoinHintOptions.java:
##########
@@ -100,6 +100,12 @@ public class LookupJoinHintOptions {
.noDefaultValue()
.withDescription("Max attempt number of the 'fixed-delay'
retry strategy.");
+ public static final ConfigOption<Boolean> SHUFFLE =
+ key("shuffle")
Review Comment:
Should it be "custom-shuffle" instead of "shuffle"? Shuffle should always be
there, the difference is whether custom shuffle is used.
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/connector/source/LookupRuntimeProviderContext.java:
##########
@@ -35,15 +35,28 @@ public final class LookupRuntimeProviderContext implements
LookupTableSource.Loo
private final int[][] lookupKeys;
+ private final boolean preferCustomShuffle;
+
public LookupRuntimeProviderContext(int[][] lookupKeys) {
Review Comment:
This constructor may be removed.
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalLookupJoin.scala:
##########
@@ -42,15 +43,22 @@ class BatchPhysicalLookupJoin(
temporalTable: RelOptTable,
tableCalcProgram: Option[RexProgram],
joinInfo: JoinInfo,
- joinType: JoinRelType)
+ joinType: JoinRelType,
+ lookupHint: Option[RelHint] = Option.empty,
+ enableLookupShuffle: Boolean = false,
+ preferCustomShuffle: Boolean = false)
Review Comment:
Would it be better to rename both "LookupShuffle" and "CustomShuffle" to
"CustomLookupShuffle"?
Besides, it might be better to clarify the difference between "prefer",
"support" and "enable".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
