reswqa commented on code in PR #25729:
URL: https://github.com/apache/flink/pull/25729#discussion_r1871215561
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalLookupJoin.scala:
##########
@@ -42,15 +43,22 @@ class BatchPhysicalLookupJoin(
temporalTable: RelOptTable,
tableCalcProgram: Option[RexProgram],
joinInfo: JoinInfo,
- joinType: JoinRelType)
+ joinType: JoinRelType,
+ lookupHint: Option[RelHint] = Option.empty,
+ enableLookupShuffle: Boolean = false,
+ preferCustomShuffle: Boolean = false)
Review Comment:
For custom shuffle, `prefer` is used instead of `enable` because the
connector may implement interface `SupportsLookupCustomShuffle`, but sometimes
it does not want to shuffle data(i.e.
SupportsLookupCustomShuffle#getPartitioner return EMPTY).
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalLookupJoin.scala:
##########
@@ -42,15 +43,22 @@ class BatchPhysicalLookupJoin(
temporalTable: RelOptTable,
tableCalcProgram: Option[RexProgram],
joinInfo: JoinInfo,
- joinType: JoinRelType)
+ joinType: JoinRelType,
+ lookupHint: Option[RelHint] = Option.empty,
+ enableLookupShuffle: Boolean = false,
+ preferCustomShuffle: Boolean = false)
Review Comment:
For custom shuffle, `prefer` is used instead of `enable` because the
connector may implement interface `SupportsLookupCustomShuffle`, but sometimes
it does not want to shuffle data(i.e.
`SupportsLookupCustomShuffle#getPartitioner` return `EMPTY`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
