davidradl commented on code in PR #25671:
URL: https://github.com/apache/flink/pull/25671#discussion_r1851894006
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTracker.java:
##########
@@ -256,7 +256,13 @@ private void
logCheckpointStatistics(AbstractCheckpointStats checkpointStats) {
.setAttribute("checkpointId",
checkpointStats.getCheckpointId())
.setAttribute("fullSize",
checkpointStats.getStateSize())
.setAttribute("checkpointedSize",
checkpointStats.getCheckpointedSize())
- .setAttribute("checkpointStatus",
checkpointStats.getStatus().name()));
+ .setAttribute("checkpointStatus",
checkpointStats.getStatus().name())
+ .setAttribute(
+ "isUnaligned",
+
Boolean.toString(checkpointStats.isUnalignedCheckpoint()))
+ .setAttribute(
+ "checkpointType",
+
checkpointStats.getProperties().getCheckpointType().getName()));
Review Comment:
in this case I assume that the name will always be "Checkpoint". I assume
savepoints do not come through here. If save points can come through here then
the span.builder first line should probable be "Snapshot" rather than
"Checkpoint".
I am thinking that the SnapshotType's SharingFilesStrategy - would be good
to include here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
