pnowojski commented on code in PR #25671:
URL: https://github.com/apache/flink/pull/25671#discussion_r1851984375
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTracker.java:
##########
@@ -256,7 +256,13 @@ private void
logCheckpointStatistics(AbstractCheckpointStats checkpointStats) {
.setAttribute("checkpointId",
checkpointStats.getCheckpointId())
.setAttribute("fullSize",
checkpointStats.getStateSize())
.setAttribute("checkpointedSize",
checkpointStats.getCheckpointedSize())
- .setAttribute("checkpointStatus",
checkpointStats.getStatus().name()));
+ .setAttribute("checkpointStatus",
checkpointStats.getStatus().name())
+ .setAttribute(
+ "isUnaligned",
+
Boolean.toString(checkpointStats.isUnalignedCheckpoint()))
+ .setAttribute(
+ "checkpointType",
+
checkpointStats.getProperties().getCheckpointType().getName()));
Review Comment:
The potential values here are:
```
public static final CheckpointType CHECKPOINT =
new CheckpointType("Checkpoint",
SharingFilesStrategy.FORWARD_BACKWARD);
public static final CheckpointType FULL_CHECKPOINT =
new CheckpointType("Full Checkpoint",
SharingFilesStrategy.FORWARD);
public static SavepointType savepoint(SavepointFormatType formatType) {
return new SavepointType("Savepoint", PostCheckpointAction.NONE,
formatType);
}
public static SavepointType terminate(SavepointFormatType formatType) {
return new SavepointType("Terminate Savepoint",
PostCheckpointAction.TERMINATE, formatType);
}
public static SavepointType suspend(SavepointFormatType formatType) {
return new SavepointType("Suspend Savepoint",
PostCheckpointAction.SUSPEND, formatType);
}
```
Savepoints do end up here, and unfortunately the `Checkpoint` name here is a
bit overloaded. However this is also consistent with other places in the code,
especially metrics/logs. There savepoints are also reported/logged as
checkpoints. So I'm not sure that I would be fine the to change the trace's
`Checkpoint` name here to `Snapshot`.
I think `SharingFilesStrategy` is superfluous. Each snapshot type is named
uniquely, so you can deduce sharing strategy based on the name/type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
