davidradl commented on code in PR #25671:
URL: https://github.com/apache/flink/pull/25671#discussion_r1851895450
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTrackerTest.java:
##########
@@ -385,11 +384,10 @@ public void addSpan(SpanBuilder spanBuilder) {
tracker.reportCompletedCheckpoint(pending.toCompletedCheckpointStats(null));
assertThat(reportedSpans.size()).isEqualTo(1);
- assertThat(
- reportedSpans.stream()
- .map(span ->
span.getAttributes().get("checkpointId"))
- .collect(Collectors.toList()))
- .containsExactly(42L);
+ Span reportedSpan = Iterables.getOnlyElement(reportedSpans);
+
assertThat(reportedSpan.getAttributes().get("checkpointId")).isEqualTo(42L);
+
assertThat(reportedSpan.getAttributes().get("checkpointType")).isEqualTo("Checkpoint");
+
assertThat(reportedSpan.getAttributes().get("isUnaligned")).isEqualTo("false");
Review Comment:
can we add a test for` isUnaligned ` true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
