tomncooper commented on PR #915: URL: https://github.com/apache/flink-kubernetes-operator/pull/915#issuecomment-2473391675
Thanks @SamBarker, using the `env.java.default-opts.all` config instead of the `env.java.opts.all` means that any user supplied opts will be appended. Duplicate opts will not cause an error, the java compiler just ignores them. Your question about differences in option sets between Flink versions is a good one and needs to be addressed. The module opts haven't changed since they were added, but that doesn't mean they won't and it is conceivable that some export/open opts will be removed in later versions that are required in earlier versions. We could do some munging of the options in the helm template (selecting them based on the configured `flink_version`) but again that relies on having a sync'd copy of the opts for each version, so smells wrong. I think @robobario's suggestion, in the [JIRA issue](https://issues.apache.org/jira/browse/FLINK-36646), of the individual Flink distribution setting these is probably the long-term solution. I will have a look at that next, in the meantime I will pull #910 into this to confirm it works for all versions. I will leave this PR up to see if anyone else has opinions. It is a short term fix until the Java 17 opts issue addressed in the main distribution or the opts change in a future Flink version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
