SamBarker commented on PR #915: URL: https://github.com/apache/flink-kubernetes-operator/pull/915#issuecomment-2472151543
> The options were added under the env.java.default-opts.all config option as these will be combined with any user supplied env.java.opts.all in the FlinkDeployment CR. Whats does the upgrade story look like for users who have already manually configured things so to run a java17 image? How does java handle duplicate instances of `--add-exports=`? I guess in theory the set of exports needs to evolve with each Flink version right? So does that mean the operator needs to support different sets for different versions of Flink? That might be a more theoretical concern given the use of `ALL-UNAMED`. This is mostly just a question from ignorance of how modules work, but if we add `ALL-UNAMED` by default does that work for users who have properly modularised Flink jobs (is that even possible?) > Once https://github.com/apache/flink-kubernetes-operator/pull/910 is merged, the full flink/java version matrix can be tested and should pass. I think we should just merge #910 into this PR, it doesn't really add any value on its own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
