tomncooper opened a new pull request, #915: URL: https://github.com/apache/flink-kubernetes-operator/pull/915
## What is the purpose of the change From Java 16 onwards, the project jigsaw java opts are now mandatory. To allow Java 17 based job images, we need to include the [java opts](https://github.com/apache/flink/blob/9d1e744371dfc38cefa76a9d34452dd7752e1c99/flink-dist/src/main/resources/config.yaml#L21) from the Flink distribution's base `conf.yaml` in the operator's helm default [`flink-conf.yaml`](https://github.com/tomncooper/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/conf/flink-conf.yaml) via the `env.java.default-opts.all` option. These will be combined with any user supplied opts (via `env.java.opts.all` in the `FlinkDeployment` CR) and ignored by JDK 8 and 11 based images as we set `-XX:IgnoreUnrecognizedVMOptions`. I have tested these settings with the `flink:1.20.0-scala_2.12-java17`, `flink:1.20.0-scala_2.12-java11` and `flink:1.20.0-scala_2.12-java8` images. Once #910 is merged, the full flink/java version matrix can be tested and should pass. ## Brief change log Added java opts from the Flink distributions default conf.yaml to the Operators helm default `flink-conf.yaml`. The options were added under the [`env.java.default-opts.all`](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/#env-java-default-opts-all) config option as these will be combined with any user supplied `env.java.opts.all` in the `FlinkDeployment` CR. ## Verifying this change This change added tests and can be verified by running the matrix in #910. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no - Core observer or reconciler logic that is regularly executed: no ## Documentation - Does this pull request introduce a new feature? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
