zhuzhurk commented on code in PR #25366: URL: https://github.com/apache/flink/pull/25366#discussion_r1799346500
########## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/util/ChainedOperatorHashInfo.java: ########## @@ -32,7 +36,7 @@ public final class ChainedOperatorHashInfo { final byte[] generatedOperatorId, final byte[] userDefinedOperatorId, final StreamNode streamNode) { - this.generatedOperatorId = generatedOperatorId; + this.generatedOperatorId = checkNotNull(generatedOperatorId); this.userDefinedOperatorId = userDefinedOperatorId; Review Comment: should be annotated with `@Nullable` ########## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/util/ChainedOperatorHashInfo.java: ########## @@ -32,7 +36,7 @@ public final class ChainedOperatorHashInfo { final byte[] generatedOperatorId, final byte[] userDefinedOperatorId, final StreamNode streamNode) { - this.generatedOperatorId = generatedOperatorId; + this.generatedOperatorId = checkNotNull(generatedOperatorId); this.userDefinedOperatorId = userDefinedOperatorId; this.streamNode = streamNode; Review Comment: checkNotNull -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org