noorall commented on code in PR #25366:
URL: https://github.com/apache/flink/pull/25366#discussion_r1798301343
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java:
##########
@@ -220,24 +197,15 @@ private StreamingJobGraphGenerator(
this.defaultStreamGraphHasher = new StreamGraphHasherV2();
this.legacyStreamGraphHashers = Arrays.asList(new
StreamGraphUserHashHasher());
- this.jobVertices = new LinkedHashMap<>();
this.builtVertices = new HashSet<>();
- this.chainedConfigs = new HashMap<>();
- this.vertexConfigs = new HashMap<>();
- this.chainedNames = new HashMap<>();
- this.chainedMinResources = new HashMap<>();
- this.chainedPreferredResources = new HashMap<>();
- this.chainedInputOutputFormats = new HashMap<>();
- this.physicalEdgesInOrder = new ArrayList<>();
this.serializationExecutor =
Preconditions.checkNotNull(serializationExecutor);
- this.chainInfos = new HashMap<>();
- this.opNonChainableOutputsCache = new LinkedHashMap<>();
-
+ this.jobVertexBuildContext =
+ new JobVertexBuildContext(streamGraph, new
AtomicBoolean(false));
Review Comment:
It is not necessary in this part. The reason for passing this value in the
constructor is only because it needs to be explicitly provided in the future
AdaptiveGraphManager.
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java:
##########
@@ -220,24 +197,15 @@ private StreamingJobGraphGenerator(
this.defaultStreamGraphHasher = new StreamGraphHasherV2();
this.legacyStreamGraphHashers = Arrays.asList(new
StreamGraphUserHashHasher());
- this.jobVertices = new LinkedHashMap<>();
this.builtVertices = new HashSet<>();
- this.chainedConfigs = new HashMap<>();
- this.vertexConfigs = new HashMap<>();
- this.chainedNames = new HashMap<>();
- this.chainedMinResources = new HashMap<>();
- this.chainedPreferredResources = new HashMap<>();
- this.chainedInputOutputFormats = new HashMap<>();
- this.physicalEdgesInOrder = new ArrayList<>();
this.serializationExecutor =
Preconditions.checkNotNull(serializationExecutor);
- this.chainInfos = new HashMap<>();
- this.opNonChainableOutputsCache = new LinkedHashMap<>();
-
+ this.jobVertexBuildContext =
+ new JobVertexBuildContext(streamGraph, new
AtomicBoolean(false));
Review Comment:
It is not necessary in this part. The reason for passing this value in the
constructor is only because it needs to be explicitly provided in the future
AdaptiveGraphManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
