noorall commented on code in PR #25366:
URL: https://github.com/apache/flink/pull/25366#discussion_r1798304428
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java:
##########
@@ -1830,10 +1950,10 @@ private void setCoLocation() {
}
}
- private static void setManagedMemoryFraction(
+ public static void setManagedMemoryFraction(
final Map<Integer, JobVertex> jobVertices,
- final Map<Integer, StreamConfig> operatorConfigs,
final Map<Integer, Map<Integer, StreamConfig>>
vertexChainedConfigs,
+ final java.util.function.Function<Integer, StreamConfig>
operatorConfigRetriever,
Review Comment:
> How about to directly pass in the context which can provides
`jobVertices`, `operatorConfigs` and `vertexChainedConfigs`?
Good idea, the changes are done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
