rkhachatryan commented on code in PR #25167:
URL: https://github.com/apache/flink/pull/25167#discussion_r1714363213
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/source/ProgressiveTimestampsAndWatermarks.java:
##########
@@ -273,6 +322,16 @@ void emitPeriodicWatermark() {
}
watermarkMultiplexer.onPeriodicEmit();
}
+
+ public void pauseOrResumeSplits(
+ Collection<String> splitsToPause, Collection<String>
splitsToResume) {
+ for (String splitId : splitsToPause) {
+ inputActivityClocks.get(splitId).markBlocked();
+ }
+ for (String splitId : splitsToResume) {
+ inputActivityClocks.get(splitId).markUnblocked();
+ }
Review Comment:
Yes, but the `WatermarkAlignmentEvent` is
[sent](https://github.com/apache/flink/blob/e126f382a1f52e228a8a361b9a828a92269b6fa3/flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java#L214)
from `SourceCoordinator` (via RPC), so I _**guess**_ these paths aren't
synchronized. I might be wrong though because I'm not familiar with this part
of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
