pnowojski commented on code in PR #25167:
URL: https://github.com/apache/flink/pull/25167#discussion_r1714052393


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/source/ProgressiveTimestampsAndWatermarks.java:
##########
@@ -273,6 +322,16 @@ void emitPeriodicWatermark() {
             }
             watermarkMultiplexer.onPeriodicEmit();
         }
+
+        public void pauseOrResumeSplits(
+                Collection<String> splitsToPause, Collection<String> 
splitsToResume) {
+            for (String splitId : splitsToPause) {
+                inputActivityClocks.get(splitId).markBlocked();
+            }
+            for (String splitId : splitsToResume) {
+                inputActivityClocks.get(splitId).markUnblocked();
+            }

Review Comment:
   AFAIU there should be such ordering guarantee. Output is released (~ 
`closed` ?) only if split for which it was created has finished. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to