pnowojski commented on code in PR #25167:
URL: https://github.com/apache/flink/pull/25167#discussion_r1714079425
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java:
##########
@@ -162,13 +172,14 @@ public void onProcessingTime(long timestamp) throws
Exception {
}
if (processedElements != lastIdleCheckProcessedElements) {
- timeSinceLastIdleCheck = now;
+ timeSinceLastIdleCheck = inputActivityClock.relativeTimeMillis();
lastIdleCheckProcessedElements = processedElements;
}
if (isIdlenessEnabled()
&& currentStatus.equals(WatermarkStatus.ACTIVE)
- && timeSinceLastIdleCheck + idleTimeout <= now) {
+ && timeSinceLastIdleCheck + idleTimeout
+ <= inputActivityClock.relativeTimeMillis()) {
Review Comment:
Not that it matters when called that rarely but sure :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
