mateczagany commented on code in PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1690999244
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkStateSnapshotUtils.java: ########## @@ -0,0 +1,395 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.utils; + +import org.apache.flink.autoscaler.utils.DateTimeUtils; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.kubernetes.operator.api.AbstractFlinkResource; +import org.apache.flink.kubernetes.operator.api.CrdConstants; +import org.apache.flink.kubernetes.operator.api.FlinkStateSnapshot; +import org.apache.flink.kubernetes.operator.api.spec.CheckpointSpec; +import org.apache.flink.kubernetes.operator.api.spec.FlinkStateSnapshotReference; +import org.apache.flink.kubernetes.operator.api.spec.FlinkStateSnapshotSpec; +import org.apache.flink.kubernetes.operator.api.spec.JobReference; +import org.apache.flink.kubernetes.operator.api.spec.SavepointSpec; +import org.apache.flink.kubernetes.operator.api.status.CheckpointType; +import org.apache.flink.kubernetes.operator.api.status.SavepointFormatType; +import org.apache.flink.kubernetes.operator.api.status.SnapshotTriggerType; +import org.apache.flink.kubernetes.operator.config.FlinkOperatorConfiguration; +import org.apache.flink.kubernetes.operator.config.KubernetesOperatorConfigOptions; +import org.apache.flink.kubernetes.operator.reconciler.ReconciliationUtils; +import org.apache.flink.kubernetes.operator.reconciler.SnapshotType; + +import io.fabric8.kubernetes.api.model.ObjectMeta; +import io.fabric8.kubernetes.client.KubernetesClient; +import org.apache.commons.lang3.StringUtils; + +import javax.annotation.Nullable; + +import java.time.Instant; +import java.util.UUID; + +import static org.apache.flink.kubernetes.operator.api.status.FlinkStateSnapshotStatus.State.ABANDONED; +import static org.apache.flink.kubernetes.operator.api.status.FlinkStateSnapshotStatus.State.COMPLETED; +import static org.apache.flink.kubernetes.operator.api.status.FlinkStateSnapshotStatus.State.IN_PROGRESS; +import static org.apache.flink.kubernetes.operator.api.status.FlinkStateSnapshotStatus.State.TRIGGER_PENDING; +import static org.apache.flink.kubernetes.operator.config.KubernetesOperatorConfigOptions.SNAPSHOT_RESOURCE_ENABLED; +import static org.apache.flink.kubernetes.operator.reconciler.SnapshotType.CHECKPOINT; +import static org.apache.flink.kubernetes.operator.reconciler.SnapshotType.SAVEPOINT; + +/** Utilities class for FlinkStateSnapshot resources. */ +public class FlinkStateSnapshotUtils { + + /** + * From a snapshot reference, return its snapshot path. If a {@link FlinkStateSnapshot} is + * referenced, it will be retrieved from Kubernetes. + * + * @param kubernetesClient kubernetes client + * @param snapshotRef snapshot reference + * @return found savepoint path + */ + public static String getAndValidateFlinkStateSnapshotPath( + KubernetesClient kubernetesClient, FlinkStateSnapshotReference snapshotRef) { + if (!StringUtils.isBlank(snapshotRef.getPath())) { + return snapshotRef.getPath(); + } + + if (StringUtils.isBlank(snapshotRef.getName())) { + throw new IllegalArgumentException( + String.format("Invalid snapshot name: %s", snapshotRef.getName())); + } + + FlinkStateSnapshot result; + if (snapshotRef.getName() != null) { + var namespace = snapshotRef.getNamespace(); + if (namespace == null) { + result = + kubernetesClient + .resources(FlinkStateSnapshot.class) + .withName(snapshotRef.getName()) + .get(); + } else { + result = + kubernetesClient + .resources(FlinkStateSnapshot.class) + .inNamespace(namespace) + .withName(snapshotRef.getName()) + .get(); + } + } else { + result = + kubernetesClient + .resources(FlinkStateSnapshot.class) + .withName(snapshotRef.getName()) + .get(); + } Review Comment: Looks like late-night code, no idea how I left it like this :D thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
