anupamaggarwal commented on PR #821:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/821#issuecomment-2246776962
Thanks for contributing this super useful feature @mateczagany 👍 !.
I am still new to the operator codebase so pls feel free to ignore if
something is not relevant, had some initial questions-
1) IIUC if a savepoint CR has a job reference (with an invalid job which
does not exist/ is not running) we would set the status field to ABANDONED.
Does it also make sense to forbid the snapshot CR creation altogether in these
cases through the validation webhook ?
2) Would it be possible to add an example FlinkStateSnapshot CR to the
examples folder ? (similar to
[basic.yaml](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/try-flink-kubernetes-operator/quick-start/#submitting-a-flink-job)
referenced in the quickstart guide). Pls ignore if you were planning on
covering this as part of the documentation PR.
3) Does it also make sense to include some of the new configs (for example
`snapshot.resource.enabled`) in `helm/*/conf/flink-conf.yaml` with the default
values commented out? I was wondering if this would give more signal to first
time users of this feature, but it seems we currently have a subset of operator
properties exposed, so wasn't entirely sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
