mateczagany commented on code in PR #821:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1690995181
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java:
##########
@@ -72,21 +74,26 @@ public class FlinkConfigManager {
private volatile Configuration defaultConfig;
private volatile FlinkOperatorConfiguration defaultOperatorConfiguration;
+ private final boolean snapshotCrdInstalled;
Review Comment:
Added the note, thank you. I am going to also note here so others can see:
This field will be determined in `FlinkOperator` when the operator starts,
by checking if `FlinkStateSnapshot` CRD is installed on the Kubernetes cluster.
When generating the default configuration for the operator,
`kubernetes.operator.snapshot.resource.enabled` will be set to false in this
class if `snapshotCrdInstalled` is false, to allow users to continue using the
operator if they upgraded from a previous version but did not install the new
`FlinkStateSnapshot` CRD.
This check and field is planned to be removed in the release after this FLIP
gets released (so hopefully 1.11 if this PR is released in 1.10).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
