Zakelly commented on PR #24653:
URL: https://github.com/apache/flink/pull/24653#issuecomment-2102099798

   > > Will the `PhysicalFilePool` close while some streams are still being 
written? There might be leaks of opened streams?
   > 
   > `PhysicalFilePool` is managed at task manager level, and asynchronous 
checkpoint threads is managed by `StreamTask`, theoretically, it is closed 
after the asynchronous checkpoint thread exits, no stream is writing when 
`PhysicalFilePool` close.
   
   Emmmmm... I'm afraid the pool share the same lifecycle with 
`FileMergingSnapshotManager`, which is at `<job, taskmanager>` level. But I 
guess you are right, those job-level resources within TM are released after 
stream task quit.
   
   Thanks for the explanation. I went through the checkpoint and restore code 
path, and have no further comments 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to