davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1905803529
@snuyanzin Can I check - did you see the cosmetic changes in [https://github.com/libenchao/flink-connector-jdbc/commits/33365-lookup-join-predicate-pushdown/](https://github.com/libenchao/flink-connector-jdbc/commits/33365-lookup-join-predicate-pushdown/) that @libenchao provided - I think some of your feedback is addressed there. @snuyanzin If you are ok with @libenchao's changes - we can proceed to merge, if not I can merge his commit into my branch and look at addressing your additional feedback. I assume there is a linter you are both using to spot the missing finals and the like, that is not in the build. What linter are you using so I can avoid these issues in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
