libenchao commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1888926645
> I am new to this area. I was looking to work within the existing design with minimal changes (as the design was added in a flip and works for scan queries. I think we have something that solves this critical issue - @libenchao would you be ok to proceed with this design and raise a subsequent issue / flip for a more elegant design. Or are you thinking this design is not appropriate and should not be merged? I need to look into your alternative proposals to understand them. I took a brief look at `JdbcRowDataLookupFunction`, and I now know why `JdbcRowDataLookupFunction` is slightly different from `JdbcRowDataInputFormat`, it's because `JdbcRowDataLookupFunction` uses `FieldNamedPreparedStatement` which does not allow `?` in the query. I'll try to come out with a solution with `FieldNamedPreparedStatement` in the coming days, but I cannot guarantee that I have enough time for that. So if you are confident with current PR, you can go ahead with merging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
