davidradl commented on PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1885629516
> I haven't gone through all the code and comments yet, there are some inline comments below, however, two questions came into my mind while reviewing the PR: > > * Why do you need to refactor `ParameterizedPredicate` and `JdbcFilterPushdownPreparedStatementVisitor`? Can you just adapt `JdbcRowDataLookupFunction` just like `JdbcRowDataInputFormat`? > * Have you considered `PrepareStatement` way to handle literals, as we have already discussed in the Jira? (I'm not sure about this, but looking at `JdbcRowDataLookupFunction`, it seems no place are handling this, so I assume that the implementation does not address that) I am new to this area. I was looking to work within the existing design with minimal changes (as the design was added ind a flip and works for scan queries. I think we have something that solves this critical issue - @libenchao would you be ok to proceed with this design and raise a subsequent issue / flip for a more elegant design. Or are you thinking this design is not appropriate and should not be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
