davidradl commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1447891687
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java:
##########
@@ -78,6 +79,8 @@ public class JdbcDynamicTableSource
private List<String> resolvedPredicates = new ArrayList<>();
private Serializable[] pushdownParams = new Serializable[0];
+ private List<ParameterizedPredicate> pushdownParameterizedPredicates = new
ArrayList<>();
Review Comment:
we tried that originally but the problem was that the template contains a ?
and backticks which could be in the column name. so last week I changed the
design to pass through the index of the placeholder, to remove ambiguity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
