iemre commented on code in PR #110:
URL:
https://github.com/apache/flink-connector-aws/pull/110#discussion_r1376004352
##########
flink-connector-aws/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtilTest.java:
##########
@@ -1021,4 +1021,28 @@ public void testGetV2ConsumerClientProperties() {
.containsKey("aws.kinesis.client.user-agent-prefix")
.hasSize(2);
}
+
+ @Test
+ public void testInvalidCustomRecoverableErrorConfiguration() {
+ exception.expect(IllegalArgumentException.class);
+ exception.expectMessage(
+ "Provided recoverable exception class could not be found:
com.NonExistentExceptionClass");
+
+ Properties testConfig = TestUtils.getStandardProperties();
+ testConfig.setProperty(
+ ConsumerConfigConstants.RECOVERABLE_EXCEPTIONS_PREFIX +
"[0].exception",
+ "com.NonExistentExceptionClass");
+
+ KinesisConfigUtil.validateConsumerConfiguration(testConfig);
+ }
+
+ @Test
+ public void testValidCustomRecoverableErrorConfiguration() {
+ Properties testConfig = TestUtils.getStandardProperties();
+ testConfig.setProperty(
+ ConsumerConfigConstants.RECOVERABLE_EXCEPTIONS_PREFIX +
"[0].exception",
Review Comment:
should probably add
`ConsumerConfigConstants.RECOVERABLE_EXCEPTIONS_EXCEPTION_SUFFIX` but it
stutters - open to suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
