iemre commented on code in PR #110:
URL:
https://github.com/apache/flink-connector-aws/pull/110#discussion_r1375229089
##########
flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/FanOutShardSubscriber.java:
##########
@@ -302,16 +313,10 @@ private void handleError(final Throwable throwable)
throws FanOutSubscriberExcep
throw new FanOutSubscriberInterruptedException(throwable);
} else if (cause instanceof FanOutSubscriberException) {
throw (FanOutSubscriberException) cause;
- } else if (cause instanceof ReadTimeoutException) {
- // ReadTimeoutException occurs naturally under backpressure
scenarios when full batches
- // take longer to
- // process than standard read timeout (default 30s). Recoverable
exceptions are intended
- // to be retried
- // indefinitely to avoid system degradation under backpressure.
The EFO connection
- // (subscription) to Kinesis
- // is closed, and reacquired once the queue of records has been
processed.
+ } else if (isDefinedAsRecoverable(cause)) {
Review Comment:
TODO: check if we need to swap the ordering of these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
