iemre commented on code in PR #110:
URL:
https://github.com/apache/flink-connector-aws/pull/110#discussion_r1367748910
##########
flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/FanOutRecordPublisher.java:
##########
@@ -289,21 +293,19 @@ private
software.amazon.awssdk.services.kinesis.model.StartingPosition toSdkV2St
Object marker = startingPosition.getStartingMarker();
switch (startingPosition.getShardIteratorType()) {
- case AT_TIMESTAMP:
- {
- Preconditions.checkNotNull(
- marker, "StartingPosition AT_TIMESTAMP date marker
is null.");
- builder.timestamp(((Date) marker).toInstant());
- break;
- }
+ case AT_TIMESTAMP: {
+ Preconditions.checkNotNull(
+ marker, "StartingPosition AT_TIMESTAMP date marker is
null.");
+ builder.timestamp(((Date) marker).toInstant());
+ break;
+ }
case AT_SEQUENCE_NUMBER:
- case AFTER_SEQUENCE_NUMBER:
- {
- Preconditions.checkNotNull(
- marker, "StartingPosition *_SEQUENCE_NUMBER
position is null.");
- builder.sequenceNumber(marker.toString());
- break;
- }
+ case AFTER_SEQUENCE_NUMBER: {
+ Preconditions.checkNotNull(
+ marker, "StartingPosition *_SEQUENCE_NUMBER position
is null.");
+ builder.sequenceNumber(marker.toString());
+ break;
+ }
Review Comment:
ignore accidental reformatting
##########
flink-connector-aws/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/FanOutRecordPublisher.java:
##########
@@ -83,11 +85,11 @@ public class FanOutRecordPublisher implements
RecordPublisher {
* over AWS SDK V2.x
*
* @param startingPosition the position in the shard to start consuming
from
- * @param consumerArn the consumer ARN of the stream consumer
- * @param subscribedShard the shard to consumer from
- * @param kinesisProxy the proxy used to talk to Kinesis services
- * @param configuration the record publisher configuration
- * @param runningSupplier a callback to query if the consumer is still
running
+ * @param consumerArn the consumer ARN of the stream consumer
+ * @param subscribedShard the shard to consumer from
+ * @param kinesisProxy the proxy used to talk to Kinesis services
+ * @param configuration the record publisher configuration
+ * @param runningSupplier a callback to query if the consumer is still
running
Review Comment:
ignore accidental reformatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
