zentol commented on code in PR #40: URL: https://github.com/apache/flink-connector-jdbc/pull/40#discussion_r1170193985
########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcTypeUtil.java: ########## @@ -26,7 +26,7 @@ import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo; import org.apache.flink.table.types.logical.LogicalTypeRoot; -import org.apache.flink.shaded.guava30.com.google.common.collect.ImmutableMap; +import com.google.common.collect.ImmutableMap; Review Comment: Like, `Lists.newArrayList` could just be replaced with `Arrays.asList`, whereas the ImmutableMap can be easily replaced by building a hashmap and wrapping it in Collections.unmodifiableMap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
