[GitHub] [flink-connector-jdbc] MartijnVisser commented on a diff in pull request #40: [FLINK-31793] remove dependency on flink-shaded guava for flink-connector-jdbc

[via GitHub]

MartijnVisser commented on code in PR #40:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/40#discussion_r1170164882


##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcTypeUtil.java:
##########
@@ -26,7 +26,7 @@
 import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo;
 import org.apache.flink.table.types.logical.LogicalTypeRoot;
 
-import org.apache.flink.shaded.guava30.com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableMap;

Review Comment:
   This means that we're still directly depending on Guava, not on a shaded 
version of Guava



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org