zentol commented on code in PR #40: URL: https://github.com/apache/flink-connector-jdbc/pull/40#discussion_r1170188117
########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcTypeUtil.java: ########## @@ -26,7 +26,7 @@ import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo; import org.apache.flink.table.types.logical.LogicalTypeRoot; -import org.apache.flink.shaded.guava30.com.google.common.collect.ImmutableMap; +import com.google.common.collect.ImmutableMap; Review Comment: Please also consider just not using guava; it seems we're using it in a very limited way that is easily replicated by either re-writing the code or copying a few methods. ########## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/JdbcTypeUtil.java: ########## @@ -26,7 +26,7 @@ import org.apache.flink.api.java.typeutils.ObjectArrayTypeInfo; import org.apache.flink.table.types.logical.LogicalTypeRoot; -import org.apache.flink.shaded.guava30.com.google.common.collect.ImmutableMap; +import com.google.common.collect.ImmutableMap; Review Comment: ~~But you have to set up that relocation in the shade-plugin.~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
