[ 
https://issues.apache.org/jira/browse/FLINK-31593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709396#comment-17709396
 ] 

Matthias Pohl commented on FLINK-31593:
---------------------------------------

[~Yanfei Lei] Roman has a point with temporary folders being referenced in the 
generated _metadata file: Do we know why this is like that? The state of the 
checkpoint shouldn't be stored in a temporary folder as far as I understand. 
The checkpoint should be rather self-contained so that we can safely copy it 
over into the tests' resources subfolder.

[~roman]'s suggestion to disable the changelog statebackend for the checkpoint 
test runs (i.e. extending the if condition in 
[SnapshotMigrationTestBase:273|https://github.com/apache/flink/blob/c89e400ae379c8b7490d9af20f82f49319895dce/flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SnapshotMigrationTestBase.java#L273])
 actually works. Would that be a viable solution? [~Yanfei Lei] Or do we hide a 
different problem with this issue? I saw that you re-enabled the changelog 
backend for the tests in 
[93146a78|https://github.com/apache/flink/commit/93146a78].

> Update reference data for Migration Tests
> -----------------------------------------
>
>                 Key: FLINK-31593
>                 URL: https://issues.apache.org/jira/browse/FLINK-31593
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Matthias Pohl
>            Assignee: Matthias Pohl
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: 
> FLINK-31593.StatefulJobSavepointMigrationITCase.create_snapshot.log, 
> FLINK-31593.StatefulJobSavepointMigrationITCase.verify_snapshot.log
>
>
> # Update {{CURRENT_VERSION in TypeSerializerUpgradeTestBase}}  with the new 
> version. This will likely fail some tests because snapshots are missing for 
> that version. Generate them, for example in 
> {{TypeSerializerUpgradeTestBase.}} 
>  # (major/minor only) Update migration tests in master to cover migration 
> from new version: (search for usages of FlinkV{{{}ersion{}}})
>  ** AbstractOperatorRestoreTestBase
>  ** CEPMigrationTest
>  ** BucketingSinkMigrationTest
>  ** FlinkKafkaConsumerBaseMigrationTest
>  ** ContinuousFileProcessingMigrationTest
>  ** WindowOperatorMigrationTest
>  ** StatefulJobSavepointMigrationITCase
>  ** StatefulJobWBroadcastStateMigrationITCase



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to