[ 
https://issues.apache.org/jira/browse/FLINK-31593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708701#comment-17708701
 ] 

Matthias Pohl commented on FLINK-31593:
---------------------------------------

Thanks [~roman]. 

{quote}
It should be possible to restore from such a checkpoint (given all the files 
are present) even with changelog disabled.
{quote}
With this statement, you're saying that eventually, the test data generation 
should succeed because of the non-determinism?! Isn't that an issue users could 
face as well?

{quote}
Alternatively, we can just generate the checkpoints with changelog (or 
materialization) disabled. 
{quote}
Based on this statement, I'd assume that we should disable changelog behavior 
for this test to ensure determinism and a successful test run from the start. 
I'm just wondering whether that's going against the intent of this test.

> Update reference data for Migration Tests
> -----------------------------------------
>
>                 Key: FLINK-31593
>                 URL: https://issues.apache.org/jira/browse/FLINK-31593
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Matthias Pohl
>            Assignee: Matthias Pohl
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: 
> FLINK-31593.StatefulJobSavepointMigrationITCase.create_snapshot.log, 
> FLINK-31593.StatefulJobSavepointMigrationITCase.verify_snapshot.log
>
>
> # Update {{CURRENT_VERSION in TypeSerializerUpgradeTestBase}}  with the new 
> version. This will likely fail some tests because snapshots are missing for 
> that version. Generate them, for example in 
> {{TypeSerializerUpgradeTestBase.}} 
>  # (major/minor only) Update migration tests in master to cover migration 
> from new version: (search for usages of FlinkV{{{}ersion{}}})
>  ** AbstractOperatorRestoreTestBase
>  ** CEPMigrationTest
>  ** BucketingSinkMigrationTest
>  ** FlinkKafkaConsumerBaseMigrationTest
>  ** ContinuousFileProcessingMigrationTest
>  ** WindowOperatorMigrationTest
>  ** StatefulJobSavepointMigrationITCase
>  ** StatefulJobWBroadcastStateMigrationITCase



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to