Rruop commented on code in PR #21968:
URL: https://github.com/apache/flink/pull/21968#discussion_r1114071247


##########
flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/sink/FileSinkSpeculativeITCase.java:
##########
@@ -100,14 +96,6 @@ void testFileSinkSpeculative()
             miniCluster.executeJobBlocking(jobGraph);

Review Comment:
   > The current way is also acceptable to me, except that the 
`@ExtendWith(MiniClusterExtension.class)` should be removed if we choose this 
way.
   If  we remove @ExtendWith(MiniClusterExtension.class) and manually using a 
MiniCluster,  the ITCaseRules::ITCASE_USE_MINICLUSTER rule will be violated. Do 
you have other better way?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to