zentol commented on code in PR #21981:
URL: https://github.com/apache/flink/pull/21981#discussion_r1113047054
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotAllocator.java:
##########
@@ -54,6 +54,18 @@ public interface SlotAllocator {
Optional<? extends VertexParallelism> determineParallelism(
JobInformation jobInformation, Collection<? extends SlotInfo>
slots);
+ /**
+ * Same as {@link #determineParallelism(JobInformation, Collection)} but
additionally determine
+ * assignment of slots to execution slot sharing groups.
+ */
+ default Optional<? extends VertexParallelismWithSlotSharing>
Review Comment:
> ? extends VertexParallelismWithSlotSharing
The existence and usage of the `VertexParallelismWithSlotSharing` is an
implementation detail of the `SlotSharingSlotAllocation`. Ideally this wouldn't
be exposed.
Essentially you are exposing the concept of slot sharing to other
components, and force all slot allocator implementations to be aware of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
