dmvk commented on code in PR #21981:
URL: https://github.com/apache/flink/pull/21981#discussion_r1112754334


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -794,7 +802,23 @@ public void goToWaitingForResources() {
                         LOG,
                         desiredResources,
                         this.initialResourceAllocationTimeout,
-                        this.resourceStabilizationTimeout));
+                        this.resourceStabilizationTimeout,
+                        null));
+    }
+
+    @Override
+    public void goToWaitingForResources(ExecutionGraph executionGraph) {

Review Comment:
   I'm wondering, do we need an extra `goToWaitingForResources` method? 🤔 
   
   Can we do something along these lines instead?
   
   ```
           final ExecutionGraph previousExecutionGraph = 
state.as(StateWithExecutionGraph.class)
                   .map(StateWithExecutionGraph::getExecutionGraph)
                   .orElse(null);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to