swathic95 commented on code in PR #481:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/481#discussion_r1047169872
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkService.java:
##########
@@ -171,11 +170,6 @@ protected void deleteClusterInternal(ObjectMeta meta,
boolean deleteHaConfigmaps
@Override
public boolean scale(ObjectMeta meta, JobSpec jobSpec, Configuration conf)
{
- if (conf.get(JobManagerOptions.SCHEDULER_MODE) == null) {
Review Comment:
Addressed the comment where it scales in appmode only if parallelism
changes, and if there is a replica change when the reactive scheduler is not
enabled, the scaling is not successful. Added test cases as well in both
session and app mode for different scenarios.
Currently scaling can happen due to the following in standalone clusters :
1) Session mode - replica change
2) App mode enabled with scheduler configured
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
