gyfora commented on code in PR #481:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/481#discussion_r1047125068


##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkServiceTest.java:
##########
@@ -177,11 +177,123 @@ public void testReactiveScale() throws Exception {
                 .getSpec()
                 .getFlinkConfiguration()
                 .remove(JobManagerOptions.SCHEDULER_MODE.key());
-        assertFalse(
+        assertTrue(

Review Comment:
   Please do not change the expected value here. Your change broke the test, 
you should restore the behaviour not adapt the test to the broken change :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to