gyfora commented on code in PR #481:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/481#discussion_r1047034839
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/StandaloneFlinkService.java:
##########
@@ -171,11 +170,6 @@ protected void deleteClusterInternal(ObjectMeta meta,
boolean deleteHaConfigmaps
@Override
public boolean scale(ObjectMeta meta, JobSpec jobSpec, Configuration conf)
{
- if (conf.get(JobManagerOptions.SCHEDULER_MODE) == null) {
Review Comment:
That's fine but what I am saying is that the StandaloneFlinkService#scale
method is used by both Application and Session cluster deployments. You cannot
simply scale an application cluster by adding more replicas unless reactive
scheduler is configured for the job.
So the check that you removed is neeeded for the application logic to work.
And it should be improved to:
```
if (conf.get(JobManagerOptions.SCHEDULER_MODE) == REACTIVE) {
return false;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
