zhuzhurk commented on code in PR #20739:
URL: https://github.com/apache/flink/pull/20739#discussion_r970342505
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategy.java:
##########
@@ -226,44 +228,71 @@ private void maybeScheduleRegions(final
Set<SchedulingPipelinedRegion> regions)
SchedulingStrategyUtils.sortPipelinedRegionsInTopologicalOrder(
schedulingTopology, regions);
Review Comment:
How about instead to do the sorting for `regionsToSchedule` before
`scheduleRegion`?
This helps to guarantee that we schedule regions in topological order, in
one scheduling batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
