[GitHub] [flink] zhuzhurk commented on a diff in pull request #20739: [FLINK-29101] PipelinedRegionSchedulingStrategy benchmark shows performance degradation

[GitBox]

zhuzhurk commented on code in PR #20739:
URL: https://github.com/apache/flink/pull/20739#discussion_r970612268


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/PipelinedRegionSchedulingStrategy.java:
##########
@@ -207,72 +214,97 @@ public void onExecutionStateChange(
             final ExecutionVertexID executionVertexId, final ExecutionState 
executionState) {
         if (executionState == ExecutionState.FINISHED) {
             maybeScheduleRegions(
-                    
getDownstreamRegionsOfVertex(schedulingTopology.getVertex(executionVertexId)));
+                    getBlockingDownstreamRegionsOfVertex(
+                            schedulingTopology.getVertex(executionVertexId)));
         }
     }
 
     @Override
     public void onPartitionConsumable(final IntermediateResultPartitionID 
resultPartitionId) {}
 
     private void maybeScheduleRegions(final Set<SchedulingPipelinedRegion> 
regions) {
-        final List<SchedulingPipelinedRegion> regionsSorted =
-                SchedulingStrategyUtils.sortPipelinedRegionsInTopologicalOrder(
-                        schedulingTopology, regions);
+        final Set<SchedulingPipelinedRegion> regionsToSchedule = new 
LinkedHashSet<>();
+        LinkedHashSet<SchedulingPipelinedRegion> nextRegions = new 
LinkedHashSet<>(regions);

Review Comment:
   It is no longer needed to be `LinkedHashSet`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org