xintongsong commented on code in PR #20739:
URL: https://github.com/apache/flink/pull/20739#discussion_r963204271
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/SchedulingStrategyUtils.java:
##########
@@ -37,22 +38,28 @@ static List<ExecutionVertexID>
sortExecutionVerticesInTopologicalOrder(
.collect(Collectors.toList());
}
- static List<SchedulingPipelinedRegion>
sortPipelinedRegionsInTopologicalOrder(
+ /**
+ * Sort pipelined regions in topological order.
+ *
+ * @param topology represent the graph contains all pipelined regions.
+ * @param regions to be sorted in topological order.
+ * @return regions in topological order, the set must preserve this order.
+ */
+ static Set<SchedulingPipelinedRegion>
sortPipelinedRegionsInTopologicalOrder(
Review Comment:
This method should explicitly returns a `LinkedHashSet`, indicating that
it's ordered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
