Github user vijikarthi commented on the issue:
https://github.com/apache/flink/pull/2275
@mxm - Thanks for your feedback and here is my response to some of your
comments.
- Do we need to run all the Yarn tests normally and secured? We already
have problems with our test execution time. Perhaps we could have one dedicated
test for secure setups and disable the other ones by default to run them
manually if needed.
[Vijay] - Yes, it is not essential to run the secure test case all the time
as it consumes more cycles. Do you have any suggestion on controlling this
through some mvn/surefire plugin configuration?
- The testing code seems overly complicated using the custom JUnit Runner.
I think we could achieve the same with @BeforeClass and @AfterClass methods in
the secure IT cases.
[Vijay] - It is little overhead but works out well with minimal changes to
the code. We could revisit and make any changes if it creates any issues.
- There is no dedicated test for the SecurityContext and the
JaasConfiguration classes
[Vijay] - Yes, will add UT for those classes.
- It would be nice to add some documentation to the configuration web page.
[Vijay] - I believe you are referring to the
https://ci.apache.org/projects/flink/flink-docs-master/setup/config.html. If
so, yes it certainly helps and I will be happy to add the details but I don't
have access to edit the page.
- We should throw exceptions if the secure configuration is not complete
instead of falling back to non-authenticated execution for either Hadoop or the
Jaas configuration. Otherwise, users might end up with a partly secure
environment.
[Vijay] - Yes, will add the validation logic
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
