Github user vijikarthi commented on the issue:
https://github.com/apache/flink/pull/2275
@mxm - I have addressed most of the feedback and pushed the changes. Please
take a look when you get a chance.
Regarding the secure test cases,
- HDFS and Yarn are handled through the @BeforeClass and @AfterClass style
and they do not use custom JRunner implementation. As you have suggested, I
could keep just one or two tests for each of the modules to cut down the
running time, if that's okay with you?
- Kafka tests are handled with custom JRunner and if we need to move it to
@BeforeClass and @AfterClass, then we may have to duplicate the code used in
the base classes which may not look good. For e.g., Have a look at
Kafka09ProducerSecuredITCase which is extended from Kafka09ProducerITCase which
has 2 level of parent classes (KafkaProducerTestBase & KafkaTestBase). If we
write a separate test case for secure cluster, then I may have to duplicate
some of these base class code which can be avoided if we use custom JRunner. We
could still limit the number of test cases to just one or two to minimize the
running time. Please let me know your thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
