Github user mxm commented on the issue:

    https://github.com/apache/flink/pull/2275
  
    I've passed through your changes. Great work! Thanks a lot for the 
documentation, it was very helpful. Please don't be scared by all the comments, 
most of them are minor. The most important points:
    
    - Do we need to run all the Yarn tests normally and secured? We already 
have problems with our test execution time. Perhaps we could have one dedicated 
test for secure setups and disable the other ones by default to run them 
manually if needed.
    
    - The testing code seems overly complicated using the custom JUnit Runner. 
I think we could achieve the same with `@BeforeClass` and `@AfterClass` methods 
in the secure IT cases. 
    
    - There is no dedicated test for the `SecurityContext` and the 
`JaasConfiguration` classes
    
    - It would be nice to add some documentation to the configuration web page.
    
    - We should throw exceptions if the secure configuration is not complete 
instead of falling back to non-authenticated execution for either Hadoop or the 
Jaas configuration. Otherwise, users might end up with a partly secure 
environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to