NicoK commented on a change in pull request #16964:
URL: https://github.com/apache/flink/pull/16964#discussion_r697310873



##########
File path: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java
##########
@@ -61,7 +61,9 @@
         public DBOptions createDBOptions(Collection<AutoCloseable> 
handlesToClose) {
             return new DBOptions()
                     .setUseFsync(false)
-                    .setInfoLogLevel(InfoLogLevel.HEADER_LEVEL)
+                    .setInfoLogLevel(InfoLogLevel.INFO_LEVEL)
+                    .setMaxLogFileSize(DEFAULT_LOG_FILE_SIZE)
+                    .setKeepLogFileNum(DEFAULT_LOG_FILE_NUM)

Review comment:
       Just looking at the documentation, however, it is a bit misleading that 
the options mentioned from `RocksDBConfigurableOptions` do not contain any 
defaults but on the other hand, some other config sections then describe the 
actual default values. This is a bit unexpected!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to