NicoK commented on a change in pull request #16964:
URL: https://github.com/apache/flink/pull/16964#discussion_r697310613
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java
##########
@@ -221,6 +229,9 @@ public ColumnFamilyOptions
createColumnOptions(Collection<AutoCloseable> handles
// ------------------------------------------------------------------------
+ public static final long DEFAULT_LOG_FILE_SIZE = 10 * 1024 * 1024L;
+ public static final int DEFAULT_LOG_FILE_NUM = 10;
Review comment:
Regardless of where to set these parameters (as referred to in the other
comment), I believe, you may have more expertise regarding how large these log
files usually get, so I'll trust you on this part (10 x 10 MB).
Just looking at the documentation, however, it is a bit misleading that the
options mentioned from `RocksDBConfigurableOptions` do not contain any defaults
but on the other hand, some other config sections then describe the actual
default values. This is a bit unexpected!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
