NicoK commented on a change in pull request #16964:
URL: https://github.com/apache/flink/pull/16964#discussion_r697287286
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java
##########
@@ -221,6 +229,9 @@ public ColumnFamilyOptions
createColumnOptions(Collection<AutoCloseable> handles
// ------------------------------------------------------------------------
+ public static final long DEFAULT_LOG_FILE_SIZE = 10 * 1024 * 1024L;
+ public static final int DEFAULT_LOG_FILE_NUM = 10;
Review comment:
It would also be nicer to have the defaults in
`RocksDBConfigurableOptions` together with the parameters - this also makes
them documented automatically!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
