XComp commented on a change in pull request #16286: URL: https://github.com/apache/flink/pull/16286#discussion_r663940924
########## File path: flink-clients/src/main/java/org/apache/flink/client/deployment/application/FromJarEntryClassInformationProvider.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.client.deployment.application; + +import org.apache.flink.client.program.PackagedProgramUtils; +import org.apache.flink.util.Preconditions; + +import javax.annotation.Nullable; + +import java.io.File; +import java.util.Optional; + +/** + * {@code FromJarEntryClassInformationProvider} is used for cases where the Jar archive is + * explicitly specified. + */ +public class FromJarEntryClassInformationProvider implements EntryClassInformationProvider { + + private final File jarFile; + private final String jobClassName; + + /** + * Creates a {@code FromJarEntryClassInformationProvider} for a custom Jar archive. At least the + * {@code jarFile} or the {@code jobClassName} has to be set. + * + * @param jarFile The Jar archive. + * @param jobClassName The name of the job class. + * @return The {@code FromJarEntryClassInformationProvider} referring to the passed information. + */ + public static FromJarEntryClassInformationProvider createFromCustomJar( + File jarFile, @Nullable String jobClassName) { + return new FromJarEntryClassInformationProvider(jarFile, jobClassName); Review comment: I rather don't want to change the failure logic as part of this PR. Just by looking at the code, it would be possible, I guess. But I'm hesitant to do this because it might open other refactoring efforts which I want to avoid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
