XComp commented on a change in pull request #16286:
URL: https://github.com/apache/flink/pull/16286#discussion_r662117121
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/program/PackagedProgramRetrieverImplTest.java
##########
@@ -590,4 +567,25 @@ private JobGraph retrieveJobGraph(
packagedProgram, configuration, defaultParallelism,
false);
return PipelineExecutorUtils.getJobGraph(pipeline, configuration);
}
+
+ private static List<String>
extractRelativizedURLsForJarsFromDirectory(File directory)
+ throws MalformedURLException {
+ Preconditions.checkArgument(
+ directory.listFiles() != null,
+ "The passed File does not seem to be a directory: " +
directory.getAbsolutePath());
Review comment:
I initially thought the same. But objected it because in the end we're
using `listFiles` in the code. And `listFiles` does not only return `null` in
case of it not being a directory. But I udpated the error message to reflect
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
