XComp commented on a change in pull request #16286: URL: https://github.com/apache/flink/pull/16286#discussion_r663839349
########## File path: flink-clients/src/main/java/org/apache/flink/client/deployment/application/FromJarEntryClassInformationProvider.java ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.client.deployment.application; + +import org.apache.flink.client.program.PackagedProgramUtils; +import org.apache.flink.util.Preconditions; + +import javax.annotation.Nullable; + +import java.io.File; +import java.util.Optional; + +/** + * {@code FromJarEntryClassInformationProvider} is used for cases where the Jar archive is + * explicitly specified. Review comment: I thought about it once more. I got the precondition from [PackagedProgram:687](https://github.com/apache/flink/blob/c08bef1f7913eb1c416c278354fd62b82b172549/flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java#L687) not realizing that the `FromJarEntryClassInformationProvider` is actually on used for the PyFlink (where the Jar and the job class name are explicitly given) or [if a jarFile is specified in DefaultPackagedProgramRetriever](https://github.com/XComp/flink/blob/FLINK-21445/flink-clients/src/main/java/org/apache/flink/client/program/DefaultPackagedProgramRetriever.java#L128). Hence, we can make the implementation more stricter which makes the JavaDoc valid again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
